-
Notifications
You must be signed in to change notification settings - Fork 22
Add support for targeting FreeBSD #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25d8ea0
to
3a05519
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a few nits. Thank you so much for this!
Would you mind also updating README.md
to mention this new target platform? A post on Swift Forums could also help people to test drive this.
Also, we need to keep compatibility with Swift 6.0 for now, that's why those jobs are failing.
3a05519
to
b3d6435
Compare
b3d6435
to
d8ac8be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, a few more formatting nits after having another look
d8ac8be
to
7b6405c
Compare
The Swift SDK Generator project should be able to generate SDKs that target FreeBSD systems. FreeBSD is much simpler than Linux. We only require the user to provide their desired architecture and FreeBSD version. This script will then download the FreeBSD base system content and create a sysroot suitable for use with Swift Package Manager. Because there are not currently any Swift toolchains for FreeBSD available on swift.org, we require the user to provide a path to a pre-built toolchain if they want the SDK to support building Swift code. In the future, we can download the Swift toolchain like we do for Linux in lieu of requiring the user to provide it.
7b6405c
to
c18bf54
Compare
@swift-ci test |
The Swift SDK Generator project should be able to generate SDKs that target FreeBSD systems.
FreeBSD is much simpler than Linux. We only require the user to provide their desired architecture and FreeBSD version. This script will then download the FreeBSD base system content and create a sysroot suitable for use with Swift Package Manager.
Because there are not currently any Swift toolchains for FreeBSD available on swift.org, we require the user to provide a path to a pre-built toolchain if they want the SDK to support building Swift code. In the future, we can download the Swift toolchain like we do for Linux in lieu of requiring the user to provide it.